]> git.ipfire.org Git - thirdparty/qemu.git/commit
ui/vnc: fix skipping SASL SSF on UNIX sockets
authorDaniel P. Berrangé <berrange@redhat.com>
Wed, 11 Sep 2024 12:13:01 +0000 (13:13 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Tue, 22 Oct 2024 10:44:23 +0000 (11:44 +0100)
commitc0a9c92bd5a9c410a2b981f4d88f5584b55c1dfd
treec3d893bdcd9b5f4c5c1496166462ee10ab8fe821
parente9eabcc911a2056a91e37384f002610351ca0907
ui/vnc: fix skipping SASL SSF on UNIX sockets

The 'is_unix' flag is set on the VNC server during startup, however,
a regression in:

  commit 8bd22f477f68bbd7a9c88e926e7a58bf65605e39
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Fri Feb 3 12:06:46 2017 +0000

    ui: extract code to connect/listen from vnc_display_open

meant we stopped setting the 'is_unix' flag when QEMU listens for
VNC sockets, only setting when QEMU does a reverse VNC connection.

Rather than fixing setting of the 'is_unix' flag, remove it, and
directly check the live client socket address. This is more robust
to a possible situation where the VNC server was listening on a
mixture of INET and UNIX sockets.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
ui/vnc-auth-sasl.c
ui/vnc.c
ui/vnc.h