]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Add missing bad-PGconn guards in libpq entry points.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 15 Aug 2022 19:40:07 +0000 (15:40 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 15 Aug 2022 19:40:07 +0000 (15:40 -0400)
commitc19024d74e98e5c0ad95643ce584c52954d01b70
treebd3fce98e5bf85e3999b353101aae3a56a88418d
parente2915afbd701e548d985ce8b834cbd13ff802ea1
Add missing bad-PGconn guards in libpq entry points.

There's a convention that externally-visible libpq functions should
check for a NULL PGconn pointer, and fail gracefully instead of
crashing.  PQflush() and PQisnonblocking() didn't get that memo
though.  Also add a similar check to PQdefaultSSLKeyPassHook_OpenSSL;
while it's not clear that ordinary usage could reach that with a
null conn pointer, it's cheap enough to check, so let's be consistent.

Daniele Varrazzo and Tom Lane

Discussion: https://postgr.es/m/CA+mi_8Zm_mVVyW1iNFgyMd9Oh0Nv8-F+7Y3-BqwMgTMHuo_h2Q@mail.gmail.com
src/interfaces/libpq/fe-exec.c