]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-40791: Make compare_digest more constant-time. (GH-20444)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sat, 21 Nov 2020 09:18:41 +0000 (01:18 -0800)
committerGitHub <noreply@github.com>
Sat, 21 Nov 2020 09:18:41 +0000 (01:18 -0800)
commitc1bbca5b004b3f74d240ef8a76ff445cc1a27efb
tree902e56c276906522951a81baf8232ddbde0f3e0c
parented0201805c036e4bc26670ec7ccffefb8e219f78
bpo-40791: Make compare_digest more constant-time. (GH-20444)

* bpo-40791: Make compare_digest more constant-time.

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change GH-1 from https://bugs.python.org/issue40791 .)
(cherry picked from commit 31729366e2bc09632e78f3896dbce0ae64914f28)

Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
Misc/NEWS.d/next/Security/2020-05-28-06-06-47.bpo-40791.QGZClX.rst [new file with mode: 0644]
Modules/_operator.c