]> git.ipfire.org Git - thirdparty/qemu.git/commit
Revert "qapi: Clean up superfluous null check in qapi_dealloc_type_str()"
authorPeter Lieven <pl@kamp.de>
Thu, 8 May 2014 16:03:15 +0000 (18:03 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 21 Jul 2014 03:23:46 +0000 (22:23 -0500)
commitc230ab2ba22a6c91d690dc57bd1157c8fc243f12
tree67a2e56a0901a3c1ec54f3358254648619ac0716
parent274c96e4e12a1829def558534c4eb1a77c4865eb
Revert "qapi: Clean up superfluous null check in qapi_dealloc_type_str()"

This reverts commit 25a7017555f1b4aeb543b5d323ff4afb8f9c5437.

Turns out the argument *can* be null: QEMU now segfaults if it
receives an invalid parameter via a qmp command instead of throwing an
error.

For example:
{ "execute": "blockdev-add",
     "arguments": { "options" : { "driver": "invalid-driver" } } }

CC: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
(cherry picked from commit b690d679c1ca65d71b0544a2331d50e9f0f95116)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qapi/qapi-dealloc-visitor.c