]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Remove assertion from PortalRunMulti
authorÁlvaro Herrera <alvherre@kurilemu.de>
Thu, 17 Jul 2025 15:40:22 +0000 (17:40 +0200)
committerÁlvaro Herrera <alvherre@kurilemu.de>
Thu, 17 Jul 2025 15:40:22 +0000 (17:40 +0200)
commitc2720ac6010a06427330b3b21ac5d3d012835da5
tree3b2d546489867b3ce5f6fb5d6fd96d20e8cda751
parent6242497bb402f3fa40bab4459443374039137f31
Remove assertion from PortalRunMulti

We have an assertion to ensure that a command tag has been assigned by
the time we're done executing, but if we happen to execute a command
with no queries, the assertion would fail.  Per discussion, rather than
contort things to get a tag assigned, just remove the assertion.

Oversight in 2f9661311b83.  That commit also retained a comment that
explained logic that had been adjacent to it but diffused into various
places, leaving none apt to keep part of the comment.  Remove that part,
and rewrite what remains for extra clarity.

Bug: #18984
Backpatch-through: 13
Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/18984-0f4778a6599ac3ae@postgresql.org
src/backend/tcop/pquery.c