]> git.ipfire.org Git - people/ms/linux.git/commit
hwmon: (adt7470) Fix incorrect return code check
authorCurt Brune <curt@cumulusnetworks.com>
Thu, 8 Aug 2013 19:11:03 +0000 (12:11 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 10 Sep 2013 00:57:21 +0000 (01:57 +0100)
commitc2d9f22ac7b0b4434df8cd12b6f857647d35c3b1
tree31aa5f2c02d0028e90bc074de603155c374a8f8e
parentd03160d52da816b9f6c87d68bed5aeecaf488191
hwmon: (adt7470) Fix incorrect return code check

commit 93d783bcca69bfacc8dc739d8a050498402587b5 upstream.

In adt7470_write_word_data(), which writes two bytes using
i2c_smbus_write_byte_data(), the return codes are incorrectly AND-ed
together when they should be OR-ed together.

The return code of i2c_smbus_write_byte_data() is zero for success.

The upshot is only the first byte was ever written to the hardware.
The 2nd byte was never written out.

I noticed that trying to set the fan speed limits was not working
correctly on my system.  Setting the fan speed limits is the only
code that uses adt7470_write_word_data().  After making the change
the limit settings work and the alarms work also.

Signed-off-by: Curt Brune <curt@cumulusnetworks.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/hwmon/adt7470.c