]> git.ipfire.org Git - thirdparty/samba.git/commit
ctdb-scripts: Get connections after tickle list
authorMartin Schwenke <mschwenke@ddn.com>
Mon, 30 Sep 2024 00:50:00 +0000 (10:50 +1000)
committerMartin Schwenke <martins@samba.org>
Wed, 6 Nov 2024 23:03:42 +0000 (23:03 +0000)
commitc3695722b6316b624aa6c44cad4f44279303d1b1
tree3a695a1bf5c0e11270158d6a75db91913d1b4a2b
parent9683bb3ac2bbdf0e83c3be3681f9d1c8ee7cc327
ctdb-scripts: Get connections after tickle list

Running ss to get current connections before running ctdb gettickles
means the ss output might be out of date when the 2 lists are
compared.  Some tickles might have been added after ss was run by some
other means (e.g. SMB tickles, added internally) and they would be
deleted according to the stale ss output.

This isn't currently a problem because update_tickles() is currently
only called with port 2049, so all tickles are managed by this code.
That will change in a subsequent commit.

Changing the order means the reverse problem can occur, where
update_tickles() attempts to delete an already deleted tickle.  That
may happen occasionally but is harmless because it doesn't result in
missing information.  It (currently) just causes a message to be
logged at DEBUG level.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jerry Heyman <jheyman@ddn.com>
ctdb/config/functions