]> git.ipfire.org Git - people/arne_f/kernel.git/commit
parport: remove non-zero check on count
authorColin Ian King <colin.king@canonical.com>
Fri, 30 Jul 2021 10:07:10 +0000 (11:07 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 09:41:26 +0000 (11:41 +0200)
commitc39992bbd43800f8b8c78af6be11e39b5805e265
tree97db3aea1cc62fdcacbe3b2e7e6fe5a3a77b482c
parentb8381d3610be309c7b33900157c5857f4ca8f38f
parport: remove non-zero check on count

[ Upstream commit 0be883a0d795d9146f5325de582584147dd0dcdc ]

The check for count appears to be incorrect since a non-zero count
check occurs a couple of statements earlier. Currently the check is
always false and the dev->port->irq != PARPORT_IRQ_NONE part of the
check is never tested and the if statement is dead-code. Fix this
by removing the check on count.

Note that this code is pre-git history, so I can't find a sha for
it.

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Logically dead code")
Link: https://lore.kernel.org/r/20210730100710.27405-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/parport/ieee1284_ops.c