]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_attribute_no_sanitize_alignment() macro
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 13 Feb 2021 22:49:08 +0000 (17:49 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 13 Feb 2021 22:49:08 +0000 (17:49 -0500)
commitc3dc311ffd6417b15a467c6ea53e642577e9f00e
treef11166f5d7af9fd12f730317370dfc7f5e95a613
parent0347470b31c139aa4f1d366fbdb85f32b7f82ad0
pg_attribute_no_sanitize_alignment() macro

Modern gcc and clang compilers offer alignment sanitizers, which help to detect
pointer misalignment.  However, our codebase already contains x86-specific
crc32 computation code, which uses unalignment access.  Thankfully, those
compilers also support the attribute, which disables alignment sanitizers at
the function level.  This commit adds pg_attribute_no_sanitize_alignment(),
which wraps this attribute, and applies it to pg_comp_crc32c_sse42() function.

Back-patch of commits 993bdb9f9 and ad2ad698a, to enable doing
alignment testing in all supported branches.

Discussion: https://postgr.es/m/CAPpHfdsne3%3DT%3DfMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w%40mail.gmail.com
Discussion: https://postgr.es/m/475514.1612745257%40sss.pgh.pa.us
Author: Alexander Korotkov, revised by Tom Lane
Reviewed-by: Tom Lane
src/include/c.h
src/port/pg_crc32c_sse42.c