]> git.ipfire.org Git - thirdparty/systemd.git/commit
tree-wide: correct cases where return log_{error,warning} is used without value
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 8 Sep 2020 10:51:23 +0000 (12:51 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 8 Sep 2020 15:40:46 +0000 (17:40 +0200)
commitc413bb28df0996be99fd6b3f2335dfe8739d62fb
tree471627329fda37ea052d798907e079792df541fb
parent819528326571f3d5e7fccaf5bc72be6ca00ae78a
tree-wide: correct cases where return log_{error,warning} is used without value

In various cases, we would say 'return log_warning()' or 'return log_error()'. Those
functions return 0 if no error is passed in. For log_warning or log_error this doesn't
make sense, and we generally want to propagate the error. In the few cases where
the error should be ignored, I think it's better to split it in two, and call 'return 0'
on a separate line.
src/core/execute.c
src/escape/escape.c
src/resolve/resolved-manager.c
src/systemctl/systemctl.c
src/update-done/update-done.c
src/update-utmp/update-utmp.c