]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mlx5: Geneve, Fix handling of Geneve object id as error code
authorMaor Dickman <maord@nvidia.com>
Wed, 8 Feb 2023 15:44:06 +0000 (17:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:50:33 +0000 (13:50 +0100)
commitc4462b29eaadb0766e8ee39594bd550f33b0687a
tree795ecb8f576e50682a8f235793e58c030877804f
parenta21afd2a717ac56e73ff95d6cc6061007f913013
net/mlx5: Geneve, Fix handling of Geneve object id as error code

[ Upstream commit d28a06d7dbedc598a06bd1e53a28125f87ca5d0c ]

On success, mlx5_geneve_tlv_option_create returns non negative
Geneve object id. In case the object id is positive value the
caller functions will handle it as an error (non zero) and
will fail to offload the Geneve rule.

Fix this by changing caller function ,mlx5_geneve_tlv_option_add,
to return 0 in case valid non negative object id was provided.

Fixes: 0ccc171ea6a2 ("net/mlx5: Geneve, Manage Geneve TLV options")
Signed-off-by: Maor Dickman <maord@nvidia.com>
Reviewed-by: Raed Salem <raeds@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/lib/geneve.c