]> git.ipfire.org Git - thirdparty/linux.git/commit
nvme: fix implicit bool to flags conversion
authorPavel Begunkov <asml.silence@gmail.com>
Tue, 20 May 2025 15:14:49 +0000 (16:14 +0100)
committerChristoph Hellwig <hch@lst.de>
Wed, 4 Jun 2025 07:51:10 +0000 (09:51 +0200)
commitc4b680ac2863821e19d360fca62f78b68b1c8ece
treec65aa629fb52a5629a2e6d33c96c83377f673b12
parent10f4a7cd724e34b7a6ff96e57ac49dc0cadececc
nvme: fix implicit bool to flags conversion

nvme_map_user_request() takes flags as the last argument, but
nvme_uring_cmd_io() shoves a bool "vec" into it. It behaves as
expected because bool is converted to 0/1 and NVME_IOCTL_VEC is
defined as 1, but it's better to pass flags explicitly.

Fixes: 7b7fdb8e2dbc1 ("nvme: replace the "bool vec" arguments with flags in the ioctl path")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Anuj Gupta <anuj20.g@samsung.com>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/ioctl.c