]> git.ipfire.org Git - thirdparty/openvpn.git/commit
multi_process_float: revert part of c14c4a9e
authorSteffan Karger <steffan@karger.me>
Sat, 19 Nov 2016 17:12:46 +0000 (18:12 +0100)
committerGert Doering <gert@greenie.muc.de>
Sat, 19 Nov 2016 18:58:43 +0000 (19:58 +0100)
commitc593885997e32a683f718138f7b9273d720c63e3
treeca1550ef0aa609796533a678eee43aa6886a7680
parent8025a62c63193d9a3c70033956342b86e01f01fc
multi_process_float: revert part of c14c4a9e

Commit c14c4a9e merged the hash_remove() and hash_add() calls in
multi_process_float(), but didn't notice that the hash key (mi->real) was
updated between these calls.  So we now try to remove the *new* address
instead of the *old* address from the hash table.  This leaks memory and
might break stuff when a different client floats to the old address/port of
this client.  Restore that.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1479575566-21198-1-git-send-email-steffan@karger.me>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13128.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/multi.c