]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/intc/arm_gicv3: Add cast to match the documentation
authorAlexandra Diupina <adiupina@astralinux.ru>
Mon, 14 Oct 2024 16:05:50 +0000 (17:05 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 15 Oct 2024 16:39:58 +0000 (19:39 +0300)
commitc5f652a0532961c20bd5ba78a65288209605b522
treea2a4e30653ff8da1595cc078fa9fffc4c1d0e0d0
parent997f8d5c2b5ea4d1f07976ed54b944d6cdcdf2b6
hw/intc/arm_gicv3: Add cast to match the documentation

The result of 1 << regbit with regbit==31 has a 1 in the 32nd bit.
When cast to uint64_t (for further bitwise OR), the 32 most
significant bits will be filled with 1s. However, the documentation
states that the upper 32 bits of ICH_AP[0/1]R<n>_EL2 are reserved.

Add an explicit cast to match the documentation.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Cc: qemu-stable@nongnu.org
Fixes: d2c0c6aab6 ("hw/intc/arm_gicv3: Handle icv_nmiar1_read() for icc_nmiar1_read()")
Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
(cherry picked from commit e0c0ea6eca4f210a52b9742817586cc97b1ee434)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/intc/arm_gicv3_cpuif.c