]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/arm/smmu: Handle big-endian hosts correctly
authorPeter Maydell <peter.maydell@linaro.org>
Tue, 25 Jul 2023 09:56:51 +0000 (10:56 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 25 Jul 2023 09:56:51 +0000 (10:56 +0100)
commitc6445544d4cea2628fbad3bad09f3d3a03c749d3
treee6da816b57c81f11b43ed9b5cbcc83a0fe4ca1df
parent885fc169f09f5915ce037263d20a59eb226d473d
hw/arm/smmu: Handle big-endian hosts correctly

The implementation of the SMMUv3 has multiple places where it reads a
data structure from the guest and directly operates on it without
doing a guest-to-host endianness conversion.  Since all SMMU data
structures are little-endian, this means that the SMMU doesn't work
on a big-endian host.  In particular, this causes the Avocado test
  machine_aarch64_virt.py:Aarch64VirtMachine.test_alpine_virt_tcg_gic_max
to fail on an s390x host.

Add appropriate byte-swapping on reads and writes of guest in-memory
data structures so that the device works correctly on big-endian
hosts.

As part of this we constrain queue_read() to operate only on Cmd
structs and queue_write() on Evt structs, because in practice these
are the only data structures the two functions are used with, and we
need to know what the data structure is to be able to byte-swap its
parts correctly.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20230717132641.764660-1-peter.maydell@linaro.org
Cc: qemu-stable@nongnu.org
hw/arm/smmu-common.c
hw/arm/smmuv3.c