]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nilfs2: fix kernel bug due to missing clearing of buffer delay flag
authorRyusuke Konishi <konishi.ryusuke@gmail.com>
Tue, 15 Oct 2024 21:32:07 +0000 (06:32 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Nov 2024 01:02:40 +0000 (02:02 +0100)
commitc6f58ff2d4c552927fe9a187774e668ebba6c7aa
tree28adda8a5eff962e5b1fabc3c390d9cfcc87ffef
parent978301009be1d34fc30180dd66aa29dd2573b2a6
nilfs2: fix kernel bug due to missing clearing of buffer delay flag

commit 6ed469df0bfbef3e4b44fca954a781919db9f7ab upstream.

Syzbot reported that after nilfs2 reads a corrupted file system image
and degrades to read-only, the BUG_ON check for the buffer delay flag
in submit_bh_wbc() may fail, causing a kernel bug.

This is because the buffer delay flag is not cleared when clearing the
buffer state flags to discard a page/folio or a buffer head. So, fix
this.

This became necessary when the use of nilfs2's own page clear routine
was expanded.  This state inconsistency does not occur if the buffer
is written normally by log writing.

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Link: https://lore.kernel.org/r/20241015213300.7114-1-konishi.ryusuke@gmail.com
Fixes: 8c26c4e2694a ("nilfs2: fix issue with flush kernel thread after remount in RO mode because of driver's internal error or metadata corruption")
Reported-by: syzbot+985ada84bf055a575c07@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=985ada84bf055a575c07
Cc: stable@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nilfs2/page.c