]> git.ipfire.org Git - thirdparty/samba.git/commit
lib/torture: directly remove the dummy signal event again to avoid flapping tests
authorStefan Metzmacher <metze@samba.org>
Wed, 28 May 2025 20:13:55 +0000 (22:13 +0200)
committerStefan Metzmacher <metze@samba.org>
Mon, 2 Jun 2025 19:13:27 +0000 (19:13 +0000)
commitc716bf33a53b3f090c7e967da776958b1cd70b72
tree1fd765cfb2f4c18f92ccdc3af2177747f99c6cf9
parent1909fa3ca1ab3cdd476c7af1d07876cbca53d4e4
lib/torture: directly remove the dummy signal event again to avoid flapping tests

I don't know why but commit 57a57a189bd9a7348656990b2c888a328b524bb0:

 lib/torture: assert that a test doesn't create new talloc children of context->ev

introduced the regression thad lead to commit 3fa94d9f2fcb165d435c62badde9e3c8569ff40d:

 selftest: mark samba4.rpc.samr.passwords.lockout on ncacn_np with .samr.lockout as flapping

Doing a TALLOC_FREE(dummy_se) still means we have the
tevent_add_fd() from tevent_common_wakeup_init() cached as
talloc child of tevent_context and that is all we need here
and the test is not flagging anymore.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Jun  2 19:13:27 UTC 2025 on atb-devel-224
lib/torture/torture.c
selftest/flapping.d/samba4.rpc.samr.passwords [deleted file]