]> git.ipfire.org Git - people/ms/linux.git/commit
ocfs2: remove filesize checks for sync I/O journal commit
authorGoldwyn Rodrigues <rgoldwyn@suse.de>
Wed, 10 Dec 2014 23:41:53 +0000 (15:41 -0800)
committerJiri Slaby <jslaby@suse.cz>
Mon, 16 Feb 2015 14:16:26 +0000 (15:16 +0100)
commitc75789fb19feb86b64d60387f0e6525f05d95b64
treea622ce3051c3041a9cfbb1504f5660ffed6da853
parent0deb7f8cc68902c58b1c735d933f69994709d7e6
ocfs2: remove filesize checks for sync I/O journal commit

commit 86b9c6f3f891019b26f8e5bb11a6faa96bba54a8 upstream.

Filesize is not a good indication that the file needs to be synced.
An example where this breaks is:
 1. Open the file in O_SYNC|O_RDWR
 2. Read a small portion of the file (say 64 bytes)
 3. Lseek to starting of the file
 4. Write 64 bytes

If the node crashes, it is not written out to disk because this was not
committed in the journal and the other node which reads the file after
recovery reads stale data (even if the write on the other node was
successful)

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
Reviewed-by: Mark Fasheh <mfasheh@suse.de>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/ocfs2/file.c