]> git.ipfire.org Git - thirdparty/glibc.git/commit
posix: Fix and simplify default p{read,write}v implementation
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Tue, 2 May 2017 17:39:58 +0000 (14:39 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Mon, 15 May 2017 19:33:45 +0000 (16:33 -0300)
commitc79a72aa5cb8357c216a71015c7448a9259c8531
treecaa8eba1f2827c9aa553c3543e85ada1ea4e37e7
parentcdd45522b6e87369afc341402bda7a95bdf83380
posix: Fix and simplify default p{read,write}v implementation

Currently all architectures but microblaze use wire-up syscall for
p{readv,write}v.  Microblaze still uses the syscall emulation using
sysdep/posix/p{readv,writev}.c and it was reported in some ocasions
[1] [2] that it might have some issues with some linux specific
usage (mainly with O_DIRECT and the alignment requirement).

Although it is not an issue for virtually all the system, this
patch refactors the sysdeps/posix p{read,write}v syscall to avoid
such issue (by using posix_memalign on the buffer used on
p{read,write} call) and by refactoring it common files to avoid
the need check on defines to correct set the alias and internal
symbols.

Checked on microblaze-linux-gnu check with run-built-tests=no and
by using the sysdeps/posix implementation on x86_64-linux-gnu (just
for sanity test where it shown no regression).

* sysdeps/posix/preadv.c: Use sysdeps/posix/preadv_common.c.
* sysdeps/posix/preadv64.c: Likewise.
* sysdeps/unix/sysv/linux/preadv.c: Likewise.
* sysdeps/unix/sysv/linux/preadv64.c: Likewise.
* sysdeps/posix/pwritev.c: Use sysdeps/posix/pwritev_common.c.
* sysdeps/posix/pwritev64.c: Likewise.
* sysdeps/unix/sysv/linux/pwritev.c: Likewise.
* sysdeps/unix/sysv/linux/pwritev64.c: Likewise.
* sysdeps/posix/preadv_common.c: New file.
* sysdeps/posix/pwritev_common.c: Likewise.

[1] http://www.mail-archive.com/qemu-devel@nongnu.org/msg25282.html
[2] https://bugzilla.redhat.com/show_bug.cgi?id=563103#c8
ChangeLog
sysdeps/posix/preadv.c
sysdeps/posix/preadv64.c
sysdeps/posix/preadv_common.c [new file with mode: 0644]
sysdeps/posix/pwritev.c
sysdeps/posix/pwritev64.c
sysdeps/posix/pwritev_common.c [new file with mode: 0644]
sysdeps/unix/sysv/linux/preadv.c
sysdeps/unix/sysv/linux/preadv64.c
sysdeps/unix/sysv/linux/pwritev.c
sysdeps/unix/sysv/linux/pwritev64.c