]> git.ipfire.org Git - people/ms/linux.git/commit
cfq-iosched: handle failure of cfq group allocation
authorKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
Mon, 9 Feb 2015 13:42:49 +0000 (16:42 +0300)
committerJiri Slaby <jslaby@suse.cz>
Sun, 1 Mar 2015 22:34:19 +0000 (23:34 +0100)
commitc7d68c6977f177bbe891b1237ff27ecbd9b2571e
tree5afe4d1ad9c3c6e22a156838bad37dcf6d9b8462
parenta291f65de1bc822187f2d6c9ed40bd8e6ba31c84
cfq-iosched: handle failure of cfq group allocation

commit 69abaffec7d47a083739b79e3066cb3730eba72e upstream.

Cfq_lookup_create_cfqg() allocates struct blkcg_gq using GFP_ATOMIC.
In cfq_find_alloc_queue() possible allocation failure is not handled.
As a result kernel oopses on NULL pointer dereference when
cfq_link_cfqq_cfqg() calls cfqg_get() for NULL pointer.

Bug was introduced in v3.5 in commit cd1604fab4f9 ("blkcg: factor
out blkio_group creation"). Prior to that commit cfq group lookup
had returned pointer to root group as fallback.

This patch handles this error using existing fallback oom_cfqq.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Fixes: cd1604fab4f9 ("blkcg: factor out blkio_group creation")
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
block/cfq-iosched.c