]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Prevent underflow in KeepLogSeg().
authorNathan Bossart <nathan@postgresql.org>
Thu, 27 Apr 2023 20:43:48 +0000 (13:43 -0700)
committerNathan Bossart <nathan@postgresql.org>
Thu, 27 Apr 2023 21:31:33 +0000 (14:31 -0700)
commitc98b06e2f8655818e83a5a26ef93cc31c357614c
treeaae6524acfc2c0e8a265904a95fb33f262ec8675
parent85ec8bcce2608b8e29a1a0742282d39b29b78dda
Prevent underflow in KeepLogSeg().

The call to XLogGetReplicationSlotMinimumLSN() might return a
greater LSN than the one given to the function.  Subsequent segment
number calculations might then underflow, which could result in
unexpected behavior when removing or recyling WAL files.  This was
introduced with max_slot_wal_keep_size in c655077639.  To fix, skip
the block of code for replication slots if the LSN is greater.

Reported-by: Xu Xingwang
Author: Kyotaro Horiguchi
Reviewed-by: Junwang Zhao
Discussion: https://postgr.es/m/17903-4288d439dee856c6%40postgresql.org
Backpatch-through: 13
src/backend/access/transam/xlog.c