]> git.ipfire.org Git - people/arne_f/kernel.git/commit
USB: serial: io_edgeport: fix memory leaks in probe error path
authorJohan Hovold <johan@kernel.org>
Sun, 8 May 2016 18:07:57 +0000 (20:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Jun 2016 19:12:48 +0000 (12:12 -0700)
commitca135b0c014855ade4bbb5fec969e5ecf4ae6c3f
tree9914b4dd1f2074ca922b399187e38452233020d4
parent2f7760714163ced1b785a6f739495f12ef433015
USB: serial: io_edgeport: fix memory leaks in probe error path

commit c8d62957d450cc1a22ce3242908709fe367ddc8e upstream.

URBs and buffers allocated in attach for Epic devices would never be
deallocated in case of a later probe error (e.g. failure to allocate
minor numbers) as disconnect is then never called.

Fix by moving deallocation to release and making sure that the
URBs are first unlinked.

Fixes: f9c99bb8b3a1 ("USB: usb-serial: replace shutdown with disconnect,
release")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/io_edgeport.c