]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_stat_statements: fetch stmt location/length before it disappears.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 1 Nov 2022 16:48:01 +0000 (12:48 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 1 Nov 2022 16:48:01 +0000 (12:48 -0400)
commitca4c6764b3ee5211c93cd94f4f46a4831dbcb684
tree8af2c2b0eb1498561a244840d19439503407b7e4
parent51c24d9e21d7c36cbb6890655fd8f57270cdb15a
pg_stat_statements: fetch stmt location/length before it disappears.

When executing a utility statement, we must fetch everything
we need out of the PlannedStmt data structure before calling
standard_ProcessUtility.  In certain cases (possibly only ROLLBACK
in extended query protocol), that data structure will get freed
during command execution.  The situation is probably often harmless
in production builds, but in debug builds we intentionally overwrite
the freed memory with garbage, leading to picking up garbage values
of statement location and length, typically causing an assertion
failure later in pg_stat_statements.  In non-debug builds, if
something did go wrong it would likely lead to storing garbage
for the query string.

Report and fix by zhaoqigui (with cosmetic adjustments by me).
It's an old problem, so back-patch to all supported versions.

Discussion: https://postgr.es/m/17663-a344fd0675f92128@postgresql.org
Discussion: https://postgr.es/m/1667307420050.56657@hundsun.com
contrib/pg_stat_statements/pg_stat_statements.c