]> git.ipfire.org Git - thirdparty/valgrind.git/commit
s390x: BPRP related fixes
authorFlorian Krohm <flo2030@eich-krohm.de>
Tue, 6 May 2025 21:22:47 +0000 (21:22 +0000)
committerFlorian Krohm <flo2030@eich-krohm.de>
Tue, 6 May 2025 21:22:47 +0000 (21:22 +0000)
commitcb266a0b87b3e6d432b8f1d4d0cbe0351222d783
tree611a429042ddcfc3300a3e53768ef2bff047d9c3
parent0ce068434ec359324ff1e27f0c7bd5df8ae4e813
s390x: BPRP related fixes

objdump disassembly for BPRP looks like so:

c5 0f ff 00 00 00   bprp  0,88 <main+0x88>,8a <main+0x8a>

But the disasm-test parser assumed there could only be one
address including a symbol name on a given line. It stopped
comparison beyond that point.
The line

c5 0f ff 00 00 00   bprp  0,88 <main+0x88>,fffe <main+0xfffe>

would compare equal to the above -- a false positive.

Once fixed, BPRP testcases began failing. This is because the i3
field is 24 bit wide. So an UShort is not good enough to represent
it.
VEX/priv/guest_s390_toIR.c
none/tests/s390x/disasm-test/objdump.c
none/tests/s390x/disasm-test/verify.c