]> git.ipfire.org Git - people/ms/linux.git/commit
afs: Fix dynamic root getattr
authorDavid Howells <dhowells@redhat.com>
Tue, 21 Jun 2022 14:59:57 +0000 (15:59 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 21 Jun 2022 16:47:30 +0000 (11:47 -0500)
commitcb78d1b5efffe4cf97e16766329dd7358aed3deb
tree21ef8ae07a03eea8f99e07ea6bc322877f8202c5
parent78ca55889a549a9a194c6ec666836329b774ab6d
afs: Fix dynamic root getattr

The recent patch to make afs_getattr consult the server didn't account
for the pseudo-inodes employed by the dynamic root-type afs superblock
not having a volume or a server to access, and thus an oops occurs if
such a directory is stat'd.

Fix this by checking to see if the vnode->volume pointer actually points
anywhere before following it in afs_getattr().

This can be tested by stat'ing a directory in /afs.  It may be
sufficient just to do "ls /afs" and the oops looks something like:

        BUG: kernel NULL pointer dereference, address: 0000000000000020
        ...
        RIP: 0010:afs_getattr+0x8b/0x14b
        ...
        Call Trace:
         <TASK>
         vfs_statx+0x79/0xf5
         vfs_fstatat+0x49/0x62

Fixes: 2aeb8c86d499 ("afs: Fix afs_getattr() to refetch file status if callback break occurred")
Reported-by: Marc Dionne <marc.dionne@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
Tested-by: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Link: https://lore.kernel.org/r/165408450783.1031787.7941404776393751186.stgit@warthog.procyon.org.uk/
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/afs/inode.c