]> git.ipfire.org Git - thirdparty/qemu.git/commit
numa: properly check if numa is supported
authorIgor Mammedov <imammedo@redhat.com>
Thu, 12 Dec 2019 12:48:56 +0000 (13:48 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 11 May 2020 20:30:22 +0000 (15:30 -0500)
commitcbdfd3865bce5ca48ae4916d9a54461dbe99f49d
treee74edc527e8668b39b6c8e8d393bd77d41d9d188
parent89eebb016dcedf08c26940dcecdab3db026e9e2c
numa: properly check if numa is supported

Commit aa57020774b, by mistake used MachineClass::numa_mem_supported
to check if NUMA is supported by machine and also as unrelated change
set it to true for sbsa-ref board.

Luckily change didn't break machines that support NUMA, as the field
is set to true for them.

But the field is not intended for checking if NUMA is supported and
will be flipped to false within this release for new machine types.

Fix it:
 - by using previously used condition
      !mc->cpu_index_to_instance_props || !mc->get_default_cpu_node_id
   the first time and then use MachineState::numa_state down the road
   to check if NUMA is supported
 - dropping stray sbsa-ref chunk

Fixes: aa57020774b690a22be72453b8e91c9b5a68c516
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <1576154936-178362-3-git-send-email-imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
(cherry picked from commit fcd3f2cc124600385dba46c69a80626985c15b50)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/arm/sbsa-ref.c
hw/core/machine.c