]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration: Fix possible race when setting rp_state.error
authorFabiano Rosas <farosas@suse.de>
Mon, 18 Sep 2023 17:28:16 +0000 (14:28 -0300)
committerMichael Tokarev <mjt@tls.msk.ru>
Mon, 2 Oct 2023 23:00:54 +0000 (02:00 +0300)
commitcc3a33400c98658807be6a9d47e34b005838529d
treec578f8de48c7eba99fd4b18e4b0796516588e77f
parent0b246f8e9e02d088ad2303b337a0663b69ad9002
migration: Fix possible race when setting rp_state.error

We don't need to set the rp_state.error right after a shutdown because
qemu_file_shutdown() always sets the QEMUFile error, so the return
path thread would have seen it and set the rp error itself.

Setting the error outside of the thread is also racy because the
thread could clear it after we set it.

Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20230918172822.19052-3-farosas@suse.de>
(cherry picked from commit 28a8347281e24c2e7bba6d3301472eda41d4c096)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
migration/migration.c