]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Breakpoint location parsing: always error instead of warning
authorPedro Alves <palves@redhat.com>
Tue, 7 Nov 2017 11:00:31 +0000 (11:00 +0000)
committerPedro Alves <palves@redhat.com>
Tue, 7 Nov 2017 11:06:00 +0000 (11:06 +0000)
commitcc638e867c240546b4dbc791761099d3ca5fe4a9
tree05e697f06e2a29b97f864ecffd6e67cafa09e0e6
parentd0fe47010fc3289e081ba547a0bfcc6d07906cd2
Breakpoint location parsing: always error instead of warning

It's odd that when parsing a breakpoint or location number, we error out
in most cases, but warn in others.

  (gdb) disable 1-
  bad breakpoint number at or near: '1-'
  (gdb) disable -1
  bad breakpoint number at or near: '-1'
  (gdb) disable .foo
  bad breakpoint number at or near: '.foo'
  (gdb) disable foo.1
  Bad breakpoint number 'foo.1'
  (gdb) disable 1.foo
  warning: bad breakpoint number at or near '1.foo'

This changes GDB to always error out.  It required touching one testcase
that expected the warning.

gdb/ChangeLog:
2017-11-07  Pedro Alves  <palves@redhat.com>

* breakpoint.c (extract_bp_number_and_location): Change return
type to void.  Throw error instead of warning.
(enable_disable_command): Adjust.

gdb/testsuite/ChangeLog:
2017-11-07  Pedro Alves  <palves@redhat.com>

* gdb.base/ena-dis-br.exp: Don't expect "warning:".
gdb/ChangeLog
gdb/breakpoint.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/ena-dis-br.exp