]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/arm/aspeed_soc: Mark devices as user_creatable = false
authorThomas Huth <thuth@redhat.com>
Mon, 4 Sep 2017 14:21:55 +0000 (15:21 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 22 Sep 2017 23:12:31 +0000 (18:12 -0500)
commitcc7dd3ad3fce9baf0e869847a6ddef33f2b463ab
tree625b5eada6c447b1da9b9a5196b986170c1fce67
parentde4ad17a8ed674e672c626c5e4b7e27dc82ca55e
hw/arm/aspeed_soc: Mark devices as user_creatable = false

QEMU currently aborts if the user is accidentially trying to
do something like this:

$ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic
QEMU 2.9.93 monitor - type 'help' for more information
(qemu) device_add ast2400
Unexpected error in error_set_from_qdev_prop_error()
 at hw/core/qdev-properties.c:1032:
Aborted (core dumped)

The ast2400 SoC devices are clearly not creatable by the user since
they are using the serial_hds and nd_table arrays directly in their
realize function, so mark them with user_creatable = false.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
(cherry picked from commit 469f3da42ef4af347fa7831e1cc0bd35d17f5b83)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/arm/aspeed_soc.c