]> git.ipfire.org Git - people/arne_f/kernel.git/commit
xenbus: req->err should be updated before req->state
authorDongli Zhang <dongli.zhang@oracle.com>
Tue, 3 Mar 2020 22:14:23 +0000 (14:14 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2020 14:34:15 +0000 (16:34 +0200)
commitccbedf8c1ed38e291259c9a20010f8cb9a3d162f
tree555f007cf7f9bdcc1a6cb75d1103518cad476d5e
parent7eb4641a6ae2db87b8799c142e77081f4ee3e8b7
xenbus: req->err should be updated before req->state

[ Upstream commit 8130b9d5b5abf26f9927b487c15319a187775f34 ]

This patch adds the barrier to guarantee that req->err is always updated
before req->state.

Otherwise, read_reply() would not return ERR_PTR(req->err) but
req->body, when process_writes()->xb_write() is failed.

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Link: https://lore.kernel.org/r/20200303221423.21962-2-dongli.zhang@oracle.com
Reviewed-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/xen/xenbus/xenbus_comms.c