]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Minor cleanup/code review for "indirect toast" stuff.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 9 Feb 2015 17:30:55 +0000 (12:30 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 9 Feb 2015 17:30:55 +0000 (12:30 -0500)
commitccf655c446d9b2de98455cf29f27795e0e067779
tree2058304520cea5aecfbb670c9c872b1f9d8ba429
parent3bc4c694271bfe28b909f43d45fe5168c18ad5b8
Minor cleanup/code review for "indirect toast" stuff.

Fix some issues I noticed while fooling with an extension to allow an
additional kind of toast pointer.  Much of this is just comment
improvement, but there are a couple of actual bugs, which might or might
not be reachable today depending on what can happen during logical
decoding.  An example is that toast_flatten_tuple() failed to cover the
possibility of an indirection pointer in its input.  Back-patch to 9.4
just in case that is reachable now.

In HEAD, also correct some really minor issues with recent compression
reorganization, such as dangerously underparenthesized macros.
src/backend/access/heap/tuptoaster.c
src/include/access/tuptoaster.h
src/include/postgres.h