]> git.ipfire.org Git - thirdparty/freeradius-server.git/commit
Annotate return_overflow in mod_write() (CID #1604620) (#5437)
authorJames Jones <jejones3141@gmail.com>
Sun, 12 Jan 2025 20:49:36 +0000 (14:49 -0600)
committerGitHub <noreply@github.com>
Sun, 12 Jan 2025 20:49:36 +0000 (14:49 -0600)
commitcd4ccacf1958b1605f56d2914dbe3b1febf1a343
tree77dd938bfe0210a23dbb39da28ec68dac355bb36
parentf5010cbe05848d0308a99f9fcac33d48dcbd0e8d
Annotate return_overflow in mod_write() (CID #1604620) (#5437)

This is arguably another example of trying to return a value not
representable in the function return type. It's highly unlikely that
anyone will pass a buffer of more than SSIZE_MAX bytes, but Coverity
apparently doesn't consider that.

CIDs #1604605 and #1604616 explicitly do return error values not
representable as int, but a ridiculously large buffer allocation will
fail long before anyone calls mod_write(), so we annotate.
src/listen/tacacs/proto_tacacs_tcp.c