]> git.ipfire.org Git - people/ms/suricata.git/commit
bug #955 - Fix SSL parsing issue.
authorAnoop Saldanha <anoopsaldanha@gmail.com>
Fri, 13 Sep 2013 14:27:29 +0000 (19:57 +0530)
committerVictor Julien <victor@inliniac.net>
Tue, 24 Sep 2013 13:22:18 +0000 (15:22 +0200)
commitcd80dcbfd4616582daa39fa56960208ee8e23262
tree0bc59bbd0fe50ec9bba90d37c8a57d046de2976b
parent8c1e8556327b4fa55dd3f4e722049aea655323b8
bug #955 - Fix SSL parsing issue.

The parser wasn't carrying out a bounds check on record length while
in the middle of parsing a handshake.  As a result we would step onto the
next record header and consider it a part of the current handshake.

- Contains an unittest to test the issue.
- Disable the duplicate parser unittest registration.

The issue came to light through an irregular ssl record, which was
reported by Sebastian Roschke, via CVE-2013-5919.

Thanks to Sebastian Roschke for reporting this issue.
src/app-layer-ssl.c
src/app-layer-ssl.h
src/runmode-unittests.c