]> git.ipfire.org Git - people/arne_f/kernel.git/commit
PCI: cadence: Use bitfield for *quirk_retrain_flag* instead of bool
authorKishon Vijay Abraham I <kishon@ti.com>
Wed, 11 Aug 2021 12:33:32 +0000 (18:03 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:39:26 +0000 (12:39 +0200)
commitcdade20269a4f6094eac7a718fa873a6a40d56fa
treef7d646267ea72d1c06f56db7b0d8971664407f34
parent53347ed7cc2efee56a6ed4cfec7ea616224b37ca
PCI: cadence: Use bitfield for *quirk_retrain_flag* instead of bool

[ Upstream commit f4455748b2126a9ba2bcc9cfb2fbcaa08de29bb2 ]

No functional change. As we are intending to add additional 1-bit
members in struct j721e_pcie_data/struct cdns_pcie_rc, use bitfields
instead of bool since it takes less space. As discussed in [1],
the preference is to use bitfileds instead of bool inside structures.

[1] -> https://lore.kernel.org/linux-fsdevel/CA+55aFzKQ6Pj18TB8p4Yr0M4t+S+BsiHH=BJNmn=76-NcjTj-g@mail.gmail.com/

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20210811123336.31357-2-kishon@ti.com
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/controller/cadence/pci-j721e.c
drivers/pci/controller/cadence/pcie-cadence.h