]> git.ipfire.org Git - thirdparty/qemu.git/commit
ppc/pnv: Move the PNOR LPC address into struct PnvPnor
authorNicholas Piggin <npiggin@gmail.com>
Mon, 17 Mar 2025 04:01:25 +0000 (14:01 +1000)
committerNicholas Piggin <npiggin@gmail.com>
Thu, 20 Mar 2025 09:58:10 +0000 (19:58 +1000)
commitce5a32d18054fe468e3536f0a63026d5b196057b
treeab73739530568354bd80da9b69d52ba9ceab58c9
parent965797d19a0d0b5dbe73f1afa110576589d25003
ppc/pnv: Move the PNOR LPC address into struct PnvPnor

Rather than use the hardcoded define throughout the tree for the
PNOR LPC address, keep it within the PnvPnor object.

This should solve a dead code issue in the BMC HIOMAP checks where
Coverity (correctly) reported that the sanity checks are dead code.
We would like to keep the sanity checks without turning them into a
compile time assert in case we would like to make them configurable
in future.

Fixes: 4c84a0a4a6e5 ("ppc/pnv: Add a PNOR address and size sanity checks")
Resolves: Coverity CID 1593723
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
hw/ppc/pnv.c
hw/ppc/pnv_bmc.c
hw/ppc/pnv_pnor.c
include/hw/ppc/pnv_pnor.h