]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
bfd: linker: merge .sframe sections
authorIndu Bhagat <indu.bhagat@oracle.com>
Tue, 15 Nov 2022 23:07:04 +0000 (15:07 -0800)
committerIndu Bhagat <indu.bhagat@oracle.com>
Tue, 15 Nov 2022 23:49:47 +0000 (15:49 -0800)
commitcf0e0a0ba91664b680dff1e310f24dbe6447bd4c
tree8b52c71281b7203aa148aae0c37ec1266648e9f9
parent19e559f1c91bfaedbd2f91d85ee161f3f03fda3c
bfd: linker: merge .sframe sections

The linker merges all the input .sframe sections.  When merging, the
linker verifies that all the input .sframe sections have the same
abi/arch.

The linker uses libsframe library to perform key actions on the
.sframe sections - decode, read, and create output data.  This
implies buildsystem changes to make and install libsframe before
libbfd.

The linker places the output .sframe section in a new segment of its
own: PT_GNU_SFRAME.  A new segment is not added, however, if the
generated .sframe section is empty.

When a section is discarded from the final link, the corresponding
entries in the .sframe section for those functions are also deleted.

The linker sorts the SFrame FDEs on start address by default and sets
the SFRAME_F_FDE_SORTED flag in the .sframe section.

This patch also adds support for generation of SFrame unwind
information for the .plt* sections on x86_64.  SFrame unwind info is
generated for IBT enabled PLT, lazy/non-lazy PLT.

The existing linker option --no-ld-generated-unwind-info has been
adapted to include the control of whether .sframe unwind information
will be generated for the linker generated sections like PLT.

Changes to the linker script have been made as necessary.

ChangeLog:

* Makefile.def: Add install dependency on libsframe for libbfd.
* Makefile.in: Regenerated.
* bfd/Makefile.am: Add elf-sframe.c
* bfd/Makefile.in: Regenerated.
* bfd/bfd-in2.h (SEC_INFO_TYPE_SFRAME): Regenerated.
* bfd/configure: Regenerate.
* bfd/configure.ac: Add elf-sframe.lo.
* bfd/elf-bfd.h (struct sframe_func_bfdinfo): New struct.
(struct sframe_dec_info): Likewise.
(struct sframe_enc_info): Likewise.
(struct elf_link_hash_table): New member for encoded .sframe
object.
(struct output_elf_obj_tdata): New member.
(elf_sframe): New access macro.
(_bfd_elf_set_section_sframe): New declaration.
* bfd/elf.c (get_segment_type): Handle new segment
PT_GNU_SFRAME.
(bfd_section_from_phdr): Likewise.
(get_program_header_size): Likewise.
(_bfd_elf_map_sections_to_segments): Likewise.
* bfd/elf64-x86-64.c (elf_x86_64_link_setup_gnu_properties): Add
contents to the .sframe sections or .plt* entries.
* bfd/elflink.c (elf_section_ignore_discarded_relocs): Handle
SEC_INFO_TYPE_SFRAME.
(_bfd_elf_default_action_discarded): Handle .sframe section.
(elf_link_input_bfd): Merge .sframe section.
(bfd_elf_final_link): Write the output .sframe section.
(bfd_elf_discard_info): Handle discarding .sframe section.
* bfd/elfxx-x86.c (_bfd_x86_elf_size_dynamic_sections): Create
.sframe section for .plt and .plt.sec.
(_bfd_x86_elf_finish_dynamic_sections): Handle .sframe from
.plt* sections.
* bfd/elfxx-x86.h (PLT_SFRAME_FDE_START_OFFSET): New
definition.
(SFRAME_PLT0_MAX_NUM_FRES): Likewise.
(SFRAME_PLTN_MAX_NUM_FRES): Likewise.
(struct elf_x86_sframe_plt): New structure.
(struct elf_x86_link_hash_table): New member.
(struct elf_x86_init_table): New members for .sframe
creation.
* bfd/section.c: Add new definition SEC_INFO_TYPE_SFRAME.
* binutils/readelf.c (get_segment_type): Handle new segment
PT_GNU_SFRAME.
* ld/ld.texi: Update documentation for
--no-ld-generated-unwind-info.
* ld/scripttempl/elf.sc: Support .sframe sections.
* ld/Makefile.am (TESTSFRAMELIB): Use it.
(check-DEJAGNU): Likewise.
* ld/Makefile.in: Regenerated.
* ld/configure.ac (TESTSFRAMELIB): Set to the .so or .a like TESTBFDLIB.
* ld/configure: Regenerated.
* bfd/elf-sframe.c: New file.

include/ChangeLog:

* elf/common.h (PT_GNU_SFRAME): New definition.
* elf/internal.h (struct elf_segment_map): Handle new segment
type PT_GNU_SFRAME.

ld/testsuite/ChangeLog:

* ld/testsuite/ld-bootstrap/bootstrap.exp: Add SFRAMELIB.
* ld/testsuite/ld-aarch64/aarch64-elf.exp: Add new test
  sframe-simple-1.
* ld/testsuite/ld-aarch64/sframe-bar.s: New file.
* ld/testsuite/ld-aarch64/sframe-foo.s: Likewise.
* ld/testsuite/ld-aarch64/sframe-simple-1.d: Likewise.
* ld/testsuite/ld-sframe/sframe-empty.d: New test.
* ld/testsuite/ld-sframe/sframe-empty.s: New file.
* ld/testsuite/ld-sframe/sframe.exp: New testsuite.
* ld/testsuite/ld-x86-64/sframe-bar.s: New file.
* ld/testsuite/ld-x86-64/sframe-foo.s: Likewise.
* ld/testsuite/ld-x86-64/sframe-simple-1.d: Likewise.
* ld/testsuite/ld-x86-64/sframe-plt-1.d: Likewise.
* ld/testsuite/ld-x86-64/sframe-simple-1.d: Likewise.
* ld/testsuite/ld-x86-64/x86-64.exp: Add new tests -
  sframe-simple-1, sframe-plt-1.
* ld/testsuite/lib/ld-lib.exp: Add new proc to check if
  assembler supports SFrame section.
* ld/testsuite/ld-sframe/discard.d: New file.
* ld/testsuite/ld-sframe/discard.ld: Likewise.
* ld/testsuite/ld-sframe/discard.s: Likewise.
43 files changed:
Makefile.def
Makefile.in
bfd/Makefile.am
bfd/Makefile.in
bfd/bfd-in2.h
bfd/configure
bfd/configure.ac
bfd/elf-bfd.h
bfd/elf-sframe.c [new file with mode: 0644]
bfd/elf.c
bfd/elf64-x86-64.c
bfd/elflink.c
bfd/elfxx-x86.c
bfd/elfxx-x86.h
bfd/section.c
binutils/readelf.c
include/elf/common.h
include/elf/internal.h
include/sframe-api.h
ld/Makefile.am
ld/Makefile.in
ld/configure
ld/configure.ac
ld/ld.texi
ld/scripttempl/elf.sc
ld/testsuite/ld-aarch64/aarch64-elf.exp
ld/testsuite/ld-aarch64/sframe-bar.s [new file with mode: 0644]
ld/testsuite/ld-aarch64/sframe-foo.s [new file with mode: 0644]
ld/testsuite/ld-aarch64/sframe-simple-1.d [new file with mode: 0644]
ld/testsuite/ld-bootstrap/bootstrap.exp
ld/testsuite/ld-sframe/discard.d [new file with mode: 0644]
ld/testsuite/ld-sframe/discard.ld [new file with mode: 0644]
ld/testsuite/ld-sframe/discard.s [new file with mode: 0644]
ld/testsuite/ld-sframe/sframe-empty.d [new file with mode: 0644]
ld/testsuite/ld-sframe/sframe-empty.s [new file with mode: 0644]
ld/testsuite/ld-sframe/sframe.exp [new file with mode: 0644]
ld/testsuite/ld-x86-64/sframe-bar.s [new file with mode: 0644]
ld/testsuite/ld-x86-64/sframe-foo.s [new file with mode: 0644]
ld/testsuite/ld-x86-64/sframe-plt-1.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/sframe-simple-1.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/x86-64.exp
ld/testsuite/lib/ld-lib.exp
libsframe/sframe.c