]> git.ipfire.org Git - thirdparty/linux.git/commit
RDMA/bnxt_re: Fix some error handling paths in bnxt_re_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 1 Nov 2024 16:10:56 +0000 (17:10 +0100)
committerLeon Romanovsky <leon@kernel.org>
Sun, 3 Nov 2024 16:02:02 +0000 (11:02 -0500)
commitcf90a4d1b9ff9e09442226bdb18fec45f013db9d
tree46f076612bd595f5cfa1d079c4cbb695df3a9b1f
parent76d3ddff7153cc0bcc14a63798d19f5d0693ea71
RDMA/bnxt_re: Fix some error handling paths in bnxt_re_probe()

If bnxt_re_add_device() fails, 'en_info' still needs to be freed, as
already done in the .remove() function.

The commit in Fixes incorrectly removed this call, certainly because it
was expecting the .remove() function was called anyway. But if the probe
fails, the remove function is not called.

There is no need to call bnxt_re_remove() as it was done before, kfree()
is enough.

Fixes: a5e099e0c464 ("RDMA/bnxt_re: Fix an error path in bnxt_re_add_device")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://patch.msgid.link/9e48ff955ae55fc39a9eb1eb590d374539eab5ba.1730477345.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/bnxt_re/main.c