]> git.ipfire.org Git - thirdparty/nftables.git/commit
evaluate: release existing datatype when evaluating unary expression
authorPablo Neira Ayuso <pablo@netfilter.org>
Fri, 28 Feb 2025 14:54:55 +0000 (15:54 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 18 Jun 2025 22:01:13 +0000 (00:01 +0200)
commitcfeb80323df626276ad825910ed23e4fe21714c8
tree3997895265551cf38dea338ad106fe776169aefa
parentcdf08f27272798d63f52df017e26ac7f491fd1ce
evaluate: release existing datatype when evaluating unary expression

commit 494a6ed120065b764f07acd05789b816625e8e13 upstream.

Use __datatype_set() to release the existing datatype before assigning
the new one, otherwise ASAN reports the following memleak:

Direct leak of 104 byte(s) in 1 object(s) allocated from:
    #0 0x7fbc8a2b89cf in __interceptor_malloc ../../../../src/libsa
    #1 0x7fbc898c96c2 in xmalloc src/utils.c:31
    #2 0x7fbc8971a182 in datatype_clone src/datatype.c:1406
    #3 0x7fbc89737c35 in expr_evaluate_unary src/evaluate.c:1366
    #4 0x7fbc89758ae9 in expr_evaluate src/evaluate.c:3057
    #5 0x7fbc89726bd9 in byteorder_conversion src/evaluate.c:243
    #6 0x7fbc89739ff0 in expr_evaluate_bitwise src/evaluate.c:1491
    #7 0x7fbc8973b4f8 in expr_evaluate_binop src/evaluate.c:1600
    #8 0x7fbc89758b01 in expr_evaluate src/evaluate.c:3059
    #9 0x7fbc8975ae0e in stmt_evaluate_arg src/evaluate.c:3198
    #10 0x7fbc8975c51d in stmt_evaluate_payload src/evaluate.c:330

Fixes: faa6908fad60 ("evaluate: clone unary expression datatype to deal with dynamic datatype")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/evaluate.c