]> git.ipfire.org Git - thirdparty/glibc.git/commit
Call _dl_open_check after relocation [BZ #24259]
authorH.J. Lu <hjl.tools@gmail.com>
Mon, 1 Jul 2019 19:23:10 +0000 (12:23 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Mon, 1 Jul 2019 19:23:22 +0000 (12:23 -0700)
commitd0093c5cefb7f7a4143f3bb03743633823229cc6
treea101155130d928b491f3ef5d72172dc91efa91be
parent3db85a9814784a74536a1f0e7b7ddbfef7dc84bb
Call _dl_open_check after relocation [BZ #24259]

This is a workaround for [BZ #20839] which doesn't remove the NODELETE
object when _dl_open_check throws an exception.  Move it after relocation
in dl_open_worker to avoid leaving the NODELETE object mapped without
relocation.

[BZ #24259]
* elf/dl-open.c (dl_open_worker): Call _dl_open_check after
relocation.
* sysdeps/x86/Makefile (tests): Add tst-cet-legacy-5a,
tst-cet-legacy-5b, tst-cet-legacy-6a and tst-cet-legacy-6b.
(modules-names): Add tst-cet-legacy-mod-5a, tst-cet-legacy-mod-5b,
tst-cet-legacy-mod-5c, tst-cet-legacy-mod-6a, tst-cet-legacy-mod-6b
and tst-cet-legacy-mod-6c.
(CFLAGS-tst-cet-legacy-5a.c): New.
(CFLAGS-tst-cet-legacy-5b.c): Likewise.
(CFLAGS-tst-cet-legacy-mod-5a.c): Likewise.
(CFLAGS-tst-cet-legacy-mod-5b.c): Likewise.
(CFLAGS-tst-cet-legacy-mod-5c.c): Likewise.
(CFLAGS-tst-cet-legacy-6a.c): Likewise.
(CFLAGS-tst-cet-legacy-6b.c): Likewise.
(CFLAGS-tst-cet-legacy-mod-6a.c): Likewise.
(CFLAGS-tst-cet-legacy-mod-6b.c): Likewise.
(CFLAGS-tst-cet-legacy-mod-6c.c): Likewise.
($(objpfx)tst-cet-legacy-5a): Likewise.
($(objpfx)tst-cet-legacy-5a.out): Likewise.
($(objpfx)tst-cet-legacy-mod-5a.so): Likewise.
($(objpfx)tst-cet-legacy-mod-5b.so): Likewise.
($(objpfx)tst-cet-legacy-5b): Likewise.
($(objpfx)tst-cet-legacy-5b.out): Likewise.
(tst-cet-legacy-5b-ENV): Likewise.
($(objpfx)tst-cet-legacy-6a): Likewise.
($(objpfx)tst-cet-legacy-6a.out): Likewise.
($(objpfx)tst-cet-legacy-mod-6a.so): Likewise.
($(objpfx)tst-cet-legacy-mod-6b.so): Likewise.
($(objpfx)tst-cet-legacy-6b): Likewise.
($(objpfx)tst-cet-legacy-6b.out): Likewise.
(tst-cet-legacy-6b-ENV): Likewise.
* sysdeps/x86/tst-cet-legacy-5.c: New file.
* sysdeps/x86/tst-cet-legacy-5a.c: Likewise.
* sysdeps/x86/tst-cet-legacy-5b.c: Likewise.
* sysdeps/x86/tst-cet-legacy-6.c: Likewise.
* sysdeps/x86/tst-cet-legacy-6a.c: Likewise.
* sysdeps/x86/tst-cet-legacy-6b.c: Likewise.
* sysdeps/x86/tst-cet-legacy-mod-5.c: Likewise.
* sysdeps/x86/tst-cet-legacy-mod-5a.c: Likewise.
* sysdeps/x86/tst-cet-legacy-mod-5b.c: Likewise.
* sysdeps/x86/tst-cet-legacy-mod-5c.c: Likewise.
* sysdeps/x86/tst-cet-legacy-mod-6.c: Likewise.
* sysdeps/x86/tst-cet-legacy-mod-6a.c: Likewise.
* sysdeps/x86/tst-cet-legacy-mod-6b.c: Likewise.
* sysdeps/x86/tst-cet-legacy-mod-6c.c: Likewise.
18 files changed:
ChangeLog
elf/dl-open.c
sysdeps/x86/Makefile
sysdeps/x86/tst-cet-legacy-5.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-5a.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-5b.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-6.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-6a.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-6b.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-mod-5.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-mod-5a.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-mod-5b.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-mod-5c.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-mod-6.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-mod-6a.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-mod-6b.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-mod-6c.c [new file with mode: 0644]
sysdeps/x86/tst-cet-legacy-mod-6d.c [new file with mode: 0644]