]> git.ipfire.org Git - thirdparty/squid.git/commit
basic_pam_auth: Fix NULL-dereference issues
authorAmos Jeffries <squid3@treenet.co.nz>
Tue, 13 Nov 2012 23:41:16 +0000 (16:41 -0700)
committerAmos Jeffries <squid3@treenet.co.nz>
Tue, 13 Nov 2012 23:41:16 +0000 (16:41 -0700)
commitd02b17ee41ff50a77e91c45ba2aada33d48354e4
tree95027f1042ba71043e3d85a39ae5476cab7e35a8
parent3c18a6773e7d3011ba323e4ae3f1927b9aeab494
basic_pam_auth: Fix NULL-dereference issues

PAM session handles being used after setup failure left them NULL.

Also removes several useless checks of retval after it being explicitly
set to the value tested againt.

  Detected by Coverity Scan. Issue 740354
helpers/basic_auth/PAM/basic_pam_auth.cc