]> git.ipfire.org Git - thirdparty/nftables.git/commit
netlink_linearize: avoid strict-overflow warning in netlink_gen_bitwise()
authorThomas Haller <thaller@redhat.com>
Wed, 27 Sep 2023 12:23:28 +0000 (14:23 +0200)
committerFlorian Westphal <fw@strlen.de>
Tue, 12 Dec 2023 14:27:37 +0000 (15:27 +0100)
commitd07c874797295f425541464ac84864e591fc0614
treeb3aec4f61d5caa0ca462127183bb0bfce039e449
parent567937b5560fbcc7f6b74fb43c52e1cab2ac425a
netlink_linearize: avoid strict-overflow warning in netlink_gen_bitwise()

With gcc-13.2.1-1.fc38.x86_64:

  $ gcc -Iinclude -c -o tmp.o src/netlink_linearize.c -Werror -Wstrict-overflow=5 -O3
  src/netlink_linearize.c: In function ‘netlink_gen_bitwise’:
  src/netlink_linearize.c:1790:1: error: assuming signed overflow does not occur when changing X +- C1 cmp C2 to X cmp C2 -+ C1 [-Werror=strict-overflow]
   1790 | }
        | ^
  cc1: all warnings being treated as errors

It also makes more sense this way, where "n" is the hight of the
"binops" stack, and we check for a non-empty stack with "n > 0" and pop
the last element with "binops[--n]".

Signed-off-by: Thomas Haller <thaller@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
src/netlink_linearize.c