]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: ethtool: tsinfo: Fix dump command
authorKory Maincent <kory.maincent@bootlin.com>
Fri, 7 Mar 2025 09:12:55 +0000 (10:12 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 10 Mar 2025 20:14:25 +0000 (13:14 -0700)
commitd0a4a1b36d7a71b45972ef33762c3fc082bec1db
tree2e55a828cbb45c86735c6716b70058cd97348190
parenteab0396353be1c778eba1c0b5180176f04dd21ce
net: ethtool: tsinfo: Fix dump command

Fix missing initialization of ts_info->phc_index in the dump command,
which could cause a netdev interface to incorrectly display a PTP provider
at index 0 instead of "none".
Fix it by initializing the phc_index to -1.

In the same time, restore missing initialization of ts_info.cmd for the
IOCTL case, as it was before the transition from ethnl_default_dumpit to
custom ethnl_tsinfo_dumpit.

Also, remove unnecessary zeroing of ts_info, as it is embedded within
reply_data, which is fully zeroed two lines earlier.

Fixes: b9e3f7dc9ed95 ("net: ethtool: tsinfo: Enhance tsinfo to support several hwtstamp by net topology")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20250307091255.463559-1-kory.maincent@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/tsinfo.c