]> git.ipfire.org Git - thirdparty/samba.git/commit
vfs_fruit: use correct case FRUIT_RSRC_STREAM in readdir_attr_rfork_size()
authorRalph Boehme <slow@samba.org>
Wed, 22 May 2019 15:02:20 +0000 (17:02 +0200)
committerKarolin Seeger <kseeger@samba.org>
Fri, 21 Jun 2019 06:49:32 +0000 (06:49 +0000)
commitd1164d9f374f4b5f7a95a04a0db6213a7cd1318f
treeb7ab78b7b57523d1207bb5b5e4cc30bc65bc7010
parent8ceb048644605affc6fbefbb7d14c512d24af79e
vfs_fruit: use correct case FRUIT_RSRC_STREAM in readdir_attr_rfork_size()

This is a genuine bug, but luckily this would only impact configs which nobody
uses:

  fruit:metadata = netatalk
  fruit:resource = stream

With the above configuration the switch in readdir_attr_rfork_size() would hit
the default case and so always report resource forks as 0 bytes in size.

All deployment that I've seen that use fruit:resource=stream also use
fruit:metadata=stream, so the switch takes FRUIT_META_STREAM case which runs the
correct code readdir_attr_rfork_size_stream().

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 83179a74119de84d20f796c241aae6bccb83a68b)
source3/modules/vfs_fruit.c