]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: usb-audio: Fix potential out-of-bound access at parsing SU
authorTakashi Iwai <tiwai@suse.de>
Tue, 21 Nov 2017 16:00:32 +0000 (17:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Nov 2017 08:35:51 +0000 (08:35 +0000)
commitd1db6f6a2ccbc1f6910cdd13fd18cc7291b89656
tree8bdedd59d3e2ecb505ed3f14691d24a7436e645a
parent7940c950ca9460311cd1804f86655b1791ab128e
ALSA: usb-audio: Fix potential out-of-bound access at parsing SU

commit f658f17b5e0e339935dca23e77e0f3cad591926b upstream.

The usb-audio driver may trigger an out-of-bound access at parsing a
malformed selector unit, as it checks the header length only after
evaluating bNrInPins field, which can be already above the given
length.  Fix it by adding the length check beforehand.

Fixes: 99fc86450c43 ("ALSA: usb-mixer: parse descriptors with structs")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/mixer.c