]> git.ipfire.org Git - thirdparty/qemu.git/commit
misc/led: LED state is set opposite of what is expected
authorGlenn Miles <milesg@linux.vnet.ibm.com>
Tue, 24 Oct 2023 19:19:45 +0000 (14:19 -0500)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 31 Oct 2023 17:39:03 +0000 (20:39 +0300)
commitd241c15f75d61674927c59c43aa67711b33515f0
tree5244d1d36a552eae7c27a4d637576f53b9c31dac
parentcec02bc03781e22daa994c21e828ad7e78f7168c
misc/led: LED state is set opposite of what is expected

Testing of the LED state showed that when the LED polarity was
set to GPIO_POLARITY_ACTIVE_LOW and a low logic value was set on
the input GPIO of the LED, the LED was being turn off when it was
expected to be turned on.

Fixes: ddb67f6402 ("hw/misc/led: Allow connecting from GPIO output")
Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Message-id: 20231024191945.4135036-1-milesg@linux.vnet.ibm.com
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
(cherry picked from commit 6f83dc67168d17856744275e2a0d7a6addf6cfb9)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/misc/led.c