]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mm/filemap.c: remove bogus VM_BUG_ON
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Fri, 5 Nov 2021 20:37:10 +0000 (13:37 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Nov 2021 10:04:47 +0000 (11:04 +0100)
commitd3a14035e51b86b637ff7b7a3a8b8ad338d160aa
treecf99ba02d848a62609e0e459f30be425fd354622
parent4546a8cb993c13b0fafd0eb7f68973675851f3da
mm/filemap.c: remove bogus VM_BUG_ON

commit d417b49fff3e2f21043c834841e8623a6098741d upstream.

It is not safe to check page->index without holding the page lock.  It
can be changed if the page is moved between the swap cache and the page
cache for a shmem file, for example.  There is a VM_BUG_ON below which
checks page->index is correct after taking the page lock.

Link: https://lkml.kernel.org/r/20210818144932.940640-1-willy@infradead.org
Fixes: 5c211ba29deb ("mm: add and use find_lock_entries")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reported-by: <syzbot+c87be4f669d920c76330@syzkaller.appspotmail.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/filemap.c