Merge pull request #1030 in SNORT/snort3 from cleanup to master

Merge pull request #1030 in SNORT/snort3 from cleanup to master

Squashed commit of the following:

commit f35eaf6b9fc5d654dd428ca0ea99a0e17eddb8b1
Author: Michael Altizer <mialtize@cisco.com>
Date:   Thu Oct 5 13:53:35 2017 -0400

    build: Add an initial clang-tidy configuration

commit 9a07c7fcdd9b3dfeffb0c34eecd870c1b073b51d
Author: Michael Altizer <mialtize@cisco.com>
Date:   Thu Oct 5 14:01:10 2017 -0400

    build: Second pass of clang-tidy's modernize-use-equals-default

commit 36d9894e859ce7d7fb5ffdaebd3848d1f934f960
Author: Michael Altizer <mialtize@cisco.com>
Date:   Wed Oct 4 10:45:16 2017 -0400

    build: Remove all default destructor declarations

commit e6d34a254be93625da190a5909a7d0a01c4ecabb
Author: Michael Altizer <mialtize@cisco.com>
Date:   Mon Oct 2 19:55:24 2017 -0400

    build: Fix linking against external libiconv with autotools

commit 1eed9487c95085deba42c18dd093f9796d6c6131
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sun Oct 1 12:40:26 2017 -0400

    build: More redundancy cleanups

    Generated automatically with run-clang-tidy.py
    -header-filter="$(realpath ..)" -checks='-*,readability-redundant-*'
    -fix.

commit 6b73e322fba1e252770fd9dc4e4d62f5b71c0642
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sun Oct 1 12:28:35 2017 -0400

    build: Remove redundant declarations

    Generated automatically with run-clang-tidy.py
    -header-filter="$(realpath ..)"
    -checks='-*,readability-redundant-declaration' -fix.

commit 09715d923afad0592f23dea741cca11a1a1fbf78
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sun Oct 1 12:23:56 2017 -0400

    build: Remove redundant flow control statements

    Generated automatically with run-clang-tidy.py
    -header-filter="$(realpath ..)"
    -checks='-*,readability-redundant-control-flow' -fix.

commit 37c2e606b84aef1f765657b6bd1405ce96c124e6
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sun Oct 1 12:19:38 2017 -0400

    build: Make some more function parameters const

    Informed by un-clang-tidy.py -header-filter="$(realpath ..)"
    -checks='-*,readability-non-const-parameter'.

commit 92b7fd10c4d0ddd521df092592bfc18e9044d4d6
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sun Oct 1 11:52:38 2017 -0400

    build: Do not use size() to check containers for emptiness

    Generated automatically with run-clang-tidy.py
    -header-filter="$(realpath ..)"
    -checks='-*,readability-container-size-empty' -fix.

commit 198636c4663f59bbdae5e5624a0c802fa2b3c8db
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sun Oct 1 11:43:12 2017 -0400

    build: Do not use compare() for pure string equality tests

    Informed by run-clang-tidy.py -header-filter="$(realpath ..)"
    -checks='-*,misc-string-compare'.

commit 497609441dd1f626434f6f039b57730bc2a3a7b4
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 17:08:47 2017 -0400

    build: Improve macro safety with parentheses

    Generated automatically with run-clang-tidy.py
    -header-filter="$(realpath ..)" -checks='-*,misc-macro-parentheses'
    -fix.

commit a44cdadf99bcb6ee0b12641ddb16d9ab04451629
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 16:48:30 2017 -0400

    build: Fix a couple instances of undefined memset behavior

    Reported by run-clang-tidy.py -header-filter="$(realpath ..)"
    -checks='-*,bugprone-*'.

commit cae0cc697d7a4614ad24c9f253193a6cbd37f4e1
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 16:26:05 2017 -0400

    build: Some language performance cleanups suggested by Clang

    Informed by run-clang-tidy.py -header-filter="$(realpath ..)"
    -checks='-*,performance-*' -fix

commit 79c3b608e997e440de2c22e6d9ef1e1189994f8b
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 16:17:30 2017 -0400

    build: Make more string arguments into const references

commit b20e1e7ed64757efde9711c2c773915f749714ec
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 15:24:57 2017 -0400

    build: Modernize code with =default for special member functions

    Generated automatically with run-clang-tidy.py
    -header-filter="$(realpath ..)" -checks='-*,modernize-use-equals-default
    -fix

commit cf3d5440d22465b26b33ef15777bc1fa9d01dbc5
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 14:27:49 2017 -0400

    build: Modernize code with boolean literals

    Generated automatically with run-clang-tidy.py
    -header-filter="$(realpath ..)" -checks='-*,modernize-use-bool-literals'
    -fix

commit 63ba30a1d8e17a8296078931a0ae6980ac09204b
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 14:21:18 2017 -0400

    build: Modernize code by removing redundant void args

    Generated automatically with run-clang-tidy.py
    -header-filter="$(realpath ..)"
    -checks='-*,modernize-redundant-void-arg'

commit 8b011f9ac133492facc66223f6b9ad8b07bd7943
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 14:16:11 2017 -0400

    build: Modernize code with make_shared conversion

    Generated automatically with run-clang-tidy.py
    -header-filter="$(realpath ..)" -checks='-*,modernize-make-shared' -fix.

commit 7e20f0fa31915690207bbdff886414ca280e7e91
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 12:30:50 2017 -0400

    build: Fix many warnings reported by Clang 5

commit 32b8843706f549c911091c36a3408c913f9360a5
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 14:07:33 2017 -0400

    build: Header cleanup (feat. clang-tidy)

    Assisted by run-clang-tidy.py -header-filter="$(realpath ..)"
    -checks='-*,modernize-deprecated-headers' -fix.

commit 4f9a94abcc40f12f9424384082e4fdcc250c6152
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 12:55:40 2017 -0400

    build: Modernize code with virtual/override/final cleanups

    Generated automatically with run-clang-tidy.py -header-filter='.*'
    -checks='-*,modernize-use-override' -fix.

commit 678d1f53b78f400c5b1915d74353ded1399cd101
Author: Michael Altizer <mialtize@cisco.com>
Date:   Sat Sep 30 12:38:56 2017 -0400

    build: Modernize code with nullptr conversion

    Generated automatically with run-clang-tidy.py -header-filter='.*'
    -checks='-*,modernize-use-nullptr' -fix.