]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
projects / thirdparty / kernel / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 42ea7d7) | patch
pktgen: fix module unload for good
authorEric Dumazet <edumazet@google.com>
Thu, 17 May 2012 23:52:26 +0000 (23:52 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 May 2012 17:54:33 +0000 (13:54 -0400)
commitd4b1133558e0d417342d5d2c49e4c35b428ff20d
tree8d50b39901dbcd06d181ad505f7aff76ca9388d7tree | snapshot
parent42ea7d7f2a7356962022cdd124d9043c488ca5e2commit | diff
pktgen: fix module unload for good

commit c57b5468406 (pktgen: fix crash at module unload) did a very poor
job with list primitives.

1) list_splice() arguments were in the wrong order

2) list_splice(list, head) has undefined behavior if head is not
initialized.

3) We should use the list_splice_init() variant to clear pktgen_threads
list.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/pktgen.c diff | blob | blame | history
A mirror of Linus' kernel repository