]> git.ipfire.org Git - thirdparty/ipset.git/commit
netfilter: fix a use-after-free in mtype_destroy()
authorCong Wang <xiyou.wangcong@gmail.com>
Fri, 10 Jan 2020 19:53:08 +0000 (11:53 -0800)
committerJozsef Kadlecsik <kadlec@netfilter.org>
Wed, 15 Jan 2020 12:48:52 +0000 (13:48 +0100)
commitd5bfa437b4c0efb49873c5f5e4d2e1d543252112
tree8001bb2e632e50a06dec700ad0f993c639ed729c
parentb48328cdef146ce2a404df6c1125f54eeec44042
netfilter: fix a use-after-free in mtype_destroy()

map->members is freed by ip_set_free() right before using it in
mtype_ext_cleanup() again. So we just have to move it down.

Reported-by: syzbot+4c3cc6dbe7259dbf9054@syzkaller.appspotmail.com
Fixes: 40cd63bf33b2 ("netfilter: ipset: Support extensions which need a per data destroy function")
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Acked-by: Jozsef Kadlecsik <kadlec@netfilter.org>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
kernel/net/netfilter/ipset/ip_set_bitmap_gen.h