]> git.ipfire.org Git - thirdparty/git.git/commit
built-in add -i: do not try to `patch`/`diff` an empty list of files
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Thu, 16 Jan 2020 08:33:06 +0000 (08:33 +0000)
committerJunio C Hamano <gitster@pobox.com>
Thu, 16 Jan 2020 22:10:21 +0000 (14:10 -0800)
commitd660a30ceb9d8bd9940be82d240901c87999186b
tree1dd87ac8eb5f06dbc95bb00be5478131e0dc7bfe
parent2e697ced9d647d6998d70f010d582ba8019fe3af
built-in add -i: do not try to `patch`/`diff` an empty list of files

When the user does not select any files to `patch` or `diff`, there is
no need to call `run_add_p()` on them.

Even worse: we _have_ to avoid calling `parse_pathspec()` with an empty
list because that would trigger this error:

BUG: pathspec.c:557: PATHSPEC_PREFER_CWD requires arguments

So let's avoid doing any work on a list of files that is empty anyway.

This fixes https://github.com/git-for-windows/git/issues/2466.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
add-interactive.c